h2oai / h2oai/datatable

fread should distinguish between fill set explicitly or not set

Open
#804 7 comments 0 reactions 0 assignees View on GitHub
fread improve
Dominant language
C++
Stars
1.9k
Forks
164
Avg merge
7h 31m
Merged PRs (30d)
1

Description

Currently the default value for `fill` is `False`. However when `sep = ' '` we change `fill` to `True`. This shouldn't be the case if the user asked `fill=False` explicitly.

This FR proposes that default value for `fill` was `None`, and then `fread` can auto-detect the most appropriate value for this parameter.

See also `test_fread_issues.py::test_issue_R2535x`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.