h2oai / h2oai/datatable

FTRL fails when the target column stype changes after fit

Open
#2,888 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
1.9k
Forks
164
Avg merge
7h 31m
Merged PRs (30d)
1

Description

```
>>> from datatable.models import Ftrl
>>> from datatable import dt
>>> ft = Ftrl()
>>> DT = dt.Frame(["1", "2", "3"])
>>> res = ft.fit(DT, DT)
>>> DT = dt.Frame([1])
>>> res = ft.fit(DT, DT)
TypeError: Column label of type int8 in the left Frame cannot be joined to column label of incompatible type str32 in the right Frame
```

We should either allow this, or explicitly forbid by issuing more clear error message.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.