h2o / h2o/picohttpparser

Legacy support, what is the specification?

Open
#36 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
2.1k
Forks
274
PR merge metrics
No merged PRs in 30d

Description

The function `parse_http_version` does not accept versions below HTTP/1.0. However `parse_headers` allows only LF to mark the end of header:
https://github.com/h2o/picohttpparser/blob/2a16b2365ba30b13c218d15ed9991576358a6337/picohttpparser.c#L278

This seems non-conforming to rfc7230, what is the rationale?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in picohttpparser.c at parse_http_version and parse_headers around the linked line. Compare their handling of HTTP versions and header line endings with the relevant RFC7230 requirements, then determine whether the behavior is intentional. Done means the rationale or required correction is clearly established and covered by an appropriate project test or documentation update.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.