gyscos / gyscos/cursive

Question about contributing additional Views

Open
#131 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4.8k
Forks
270
Avg merge
5d 19h
Merged PRs (30d)
2

Description

Hey there,

I've recently started building an application using cursive and since I had the need for a few additional views I simply went ahead and implemented them myself.

I already have a lightweight `TableView` component build (https://github.com/BonsaiDen/curtable, README is lying, the crate is not yet published) and am currently finishing work on a `CalendarView` using the `chrono` crate:

![calendar1](https://cloud.githubusercontent.com/assets/124674/25059858/c2e8f020-218e-11e7-882e-fd148bff36a7.png) ![calendar2](https://cloud.githubusercontent.com/assets/124674/25059859/c462377c-218e-11e7-88f3-13b329a85ae2.png)

Now the question I have, what is the best - or simply the desired - way to contribute these views to cursive itself? :)

I could imagine that just adding them and opening a PR might not always be the best way here, since this might add additional dependencies to cursive itself (e.g. the `CalendarView` that requires `chrono`).

One solution could be to "hide" such cases behind feature flags, another way could be to publish them as separate crates with a `cursive_` prefix. The latter of course only with official permission from your side since I don't want to occupy the `cursive` namespace with my random stuff :D

So, what's your take on the topic here? I'm open for discussion! Which I think is definitely needed here since, while I'm trying to stick closely to the existing API design, the devil - as we all know - tends to lie in the details :)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.