gwt-plugins / gwt-plugins/gwt-eclipse-plugin

Importing / closed projects throw a lot of errors

Open
#514 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
117
Forks
49
PR merge metrics
No merged PRs in 30d

Description

Hello everyone,

I noticed that when importing projects, there are a lot of errors like this in the `Error Log` view:

> isGWTProject(project) hasGwtnature exception Project 'CertificateManager' is not open.

It seems to originate from [HERE](https://github.com/gwt-plugins/gwt-eclipse-plugin/blob/v4.2.0/plugins/com.gwtplugins.gwt.eclipse.core/src/com/google/gwt/eclipse/core/nature/GWTNature.java#L53-L57). I guess that the [ResourceChangeListener](https://github.com/gwt-plugins/gwt-eclipse-plugin/blob/v4.2.0/plugins/com.gwtplugins.gdt.eclipse.core/src/com/google/gdt/eclipse/core/reference/ResourceChangeListener.java) might be implemented incorrectly, assuming all projects are opened, which is then triggering the initial issue in `GWTNature#isGwtProject`.

When importing projects, we do that automatically, and initially, they are always closed before being opened. We don't have a special implementation; we rely on the Eclipse API.

Once everything is finished and the projects are all imported (and open), there are no further errors by the GWT plug-in, and everything works as expected. But this is quite annoying nevertheless.

Best,
Tobias

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.