guyskk / guyskk/pyv8

error: 'CLASSIC_MODE' is not a member of 'v8i' v8 API change ?

Open
#233 0 comments 0 reactions 0 assignees View on GitHub
auto-migrated Priority-Medium Type-Defect
Dominant language
Python
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

```
What steps will reproduce the problem?
1. V8_HOME=/opt/v8 python setup.py install
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

From the SVN

Please provide any additional information below.

INFO: Found Google v8 base on V8_HOME
running install
running bdist_egg
running egg_info
writing requirements to PyV8.egg-info/requires.txt
writing PyV8.egg-info/PKG-INFO
writing top-level names to PyV8.egg-info/top_level.txt
writing dependency_links to PyV8.egg-info/dependency_links.txt
reading manifest template 'MANIFEST.in'
writing manifest file 'PyV8.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
running build_ext
building '_PyV8' extension
gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall
-Wstrict-prototypes -fPIC -DBOOST_PYTHON_STATIC_LIB -DV8_NATIVE_REGEXP
-DENABLE_DEBUGGER_SUPPORT -DV8_TARGET_ARCH_X64 -I/opt/v8/include -I/opt/v8
-I/opt/v8/src -I/usr/local/include -I/usr/include/python2.7 -c src/Utils.cpp -o
build/temp.linux-x86_64-2.7/src/Utils.o -Wno-write-strings -g -O3
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC
but not for C++ [enabled by default]
gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall
-Wstrict-prototypes -fPIC -DBOOST_PYTHON_STATIC_LIB -DV8_NATIVE_REGEXP
-DENABLE_DEBUGGER_SUPPORT -DV8_TARGET_ARCH_X64 -I/opt/v8/include -I/opt/v8
-I/opt/v8/src -I/usr/local/include -I/usr/include/python2.7 -c
src/Exception.cpp -o build/temp.linux-x86_64-2.7/src/Exception.o
-Wno-write-strings -g -O3
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC
but not for C++ [enabled by default]
gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall
-Wstrict-prototypes -fPIC -DBOOST_PYTHON_STATIC_LIB -DV8_NATIVE_REGEXP
-DENABLE_DEBUGGER_SUPPORT -DV8_TARGET_ARCH_X64 -I/opt/v8/include -I/opt/v8
-I/opt/v8/src -I/usr/local/include -I/usr/include/python2.7 -c src/Context.cpp
-o build/temp.linux-x86_64-2.7/src/Context.o -Wno-write-strings -g -O3
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC
but not for C++ [enabled by default]
In file included from src/Context.cpp:4:0:
src/Engine.h:123:39: error: 'v8i::LanguageMode' has not been declared
void visit(py::object handler, v8i::LanguageMode mode=v8i::CLASSIC_MODE) const;
^
src/Engine.h:123:57: error: 'CLASSIC_MODE' is not a member of 'v8i'
void visit(py::object handler, v8i::LanguageMode mode=v8i::CLASSIC_MODE) const;
^
error: command 'gcc' failed with exit status 1

```

Original issue reported on code.google.com by `cap.jane...@gmail.com` on 20 Jun 2014 at 6:58

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/Engine.h, where the build fails on v8i::LanguageMode and v8i::CLASSIC_MODE, then inspect the V8 headers under /opt/v8 and the setup.py build configuration. Determine the corresponding API in the reported V8 revision and update the integration so the extension builds and installs successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.