gulpjs / gulpjs/gulp-cli

potential for black-holing log messages via transitive dependency on gulplog

Open
#237 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
408
Forks
112
PR merge metrics
No merged PRs in 30d

Description

`gulp-util.log` checks for `hasGulplog` on module initialization and if present, defers logging to `gulplog.info`, which in turn will eat any messages below `error` (I believe) unless there is explicitly an event handler for the other levels (info, warn, etc.).

This can happen 'accidentally' if a transitive dependency uses gulplog.

It _seems_ like the reasonable thing to do is to use `gulplog.error` to ensure all logging is output properly.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.