guardicore / guardicore/monkey

Update RJSF

Open
#3,770 0 comments 0 reactions 0 assignees View on GitHub
Refactor UI UI:refactoring
Dominant language
Python
Stars
7.1k
Forks
830
PR merge metrics
No merged PRs in 30d

Description

# Refactor

Simplify code complexity for generating UI from jsonschema when refactoring the whole UI.

## Tasks

- [ ] Move jsonschema generation code to the back end (API gateway layer). This code is now in `monkey_island/cc/ui/src/components/configuration-components/ReformatHook.js`
- [ ] Upgrade to the latest version of `rjsf`. See migration guide, keep in mind that the code is [not entirely migrated to react v18](https://github.com/rjsf-team/react-jsonschema-form/issues/3643)
- [ ] Remove the code that removes the defaults generated by rjsf (https://github.com/rjsf-team/react-jsonschema-form/issues/2980). This code is now in `monkey_island/cc/ui/src/components/configuration-components/UISchemaManipulators.tsx`
- [ ] (Optional) Create a facade for rjsf. This would make sure that we could exchange libraries or write our own without the need to change the interface

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.