guardicore / guardicore/monkey

Invalid configurations can be exported in the UI

Open
#3,703 0 comments 0 reactions 0 assignees View on GitHub
Bug Complexity: Medium Help wanted Impact: Low UI
Dominant language
Python
Stars
7.1k
Forks
830
PR merge metrics
No merged PRs in 30d

Description

## Describe the bug
While an invalid configuration can't be submitted through the UI, it can be exported.

Trying to import that configuration in the UI isn't allowed, so it could be frustrating for a user who didn't realise that some values were invalid while exporting.

## To Reproduce
Steps to reproduce the behavior:
1. Run Island
2. Add invalid configuration value somewhere
3. Try submitting and see warning box
4. Export and check the exported configuration for invalid value

## Expected behavior
Don't allow exporting configuration if some values are invalid.

## Screenshots
1. Added invalid IP to configuration
![image](https://github.com/guardicore/monkey/assets/44770317/c7366a4b-d160-45c3-8dfb-eb47bd833010)

5. Export modal works normally, but a warning is shown on the configuration page
![image](https://github.com/guardicore/monkey/assets/44770317/985ca208-e645-4c52-80be-f59a843380c8)

6. Warning box
![image](https://github.com/guardicore/monkey/assets/44770317/810e0dc2-91db-48c6-a3a0-9fd86eaee3a7)

7. Exported configuration
![image](https://github.com/guardicore/monkey/assets/44770317/f8fe7f13-92c1-461b-af7e-713e84a3ce2a)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.