guardicore / guardicore/monkey
Allow-redefinition in mypy
Open
Enhancement
Refactor
- Dominant language
- Python
- Stars
- 7.1k
- Forks
- 830
- PR merge metrics
- No merged PRs in 30d
Description
# Refactor
## Component(s) to be refactored
We should run mypy with `--allow-redefinition` flag. It's useful in resources/serialization. Example:
```
def get(self, exploiter: str):
exploiter = Exploiter(exploiter)
```
`exploiter` is the best name for the hypothetical "Exploiter" object. We can't change the argument to `exploiter_string`, because it's obvious that you pass strings into the url.
`--allow-redefinition` is the best way to keep code clean in this case.
Contributor guide
Assessment
This issue has not been assessed yet.