guardicore / guardicore/monkey

Refactor custom network classes

Open
#2,135 0 comments 0 reactions 0 assignees View on GitHub
Complexity: Low Impact: Medium Refactor
Dominant language
Python
Stars
7.1k
Forks
830
PR merge metrics
No merged PRs in 30d

Description

# Refactor

## Component(s) to be refactored

- infection_monkey.network_scanning.scan_target_generator

## Explanation
Some custom network classes/tuples are defined for handling IP addresses and IP networks (CIDR). Python already has built-in classes with lots of bells and whistles to handle IPs (https://docs.python.org/3/library/ipaddress.html). Where possible, refactor the Agent's code to use Python's `ipaddress` library instead of custom classes. Remove any disused code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.