guardicore / guardicore/monkey
Unify modal window styles
- Dominant language
- Python
- Stars
- 7.1k
- Forks
- 830
- PR merge metrics
- No merged PRs in 30d
Description
Some modal windows have their style inlined in their JSX:
https://github.com/guardicore/monkey/blob/bc3283c4a5177c7d08ff65bb13370d061aae60d3/monkey/monkey_island/cc/ui/src/components/ui-components/IslandMonkeyRunErrorModal.js#L72-L82
https://github.com/guardicore/monkey/blob/bc3283c4a5177c7d08ff65bb13370d061aae60d3/monkey/monkey_island/cc/ui/src/components/pages/ConfigurePage.js#L178-L195
https://github.com/guardicore/monkey/blob/26dc2aeb146a50651a0df223d979a0fdf2161a5c/monkey/monkey_island/cc/ui/src/components/configuration-components/UnsafeOptionsConfirmationModal.js#L7-L27
Other modals, such as ImageModal and ScoutsuiteRuleModal have separate style sheets.
Unify the styles for all modal windows. Use style sheets instead of hardcoding style in the JSX
Contributor guide
Assessment
This issue has not been assessed yet.