guardian / guardian/notifications-tooling

Improve email preview loading

Closed
#411 0 comments 0 reactions 1 assignee Claimed by @dblatcher View on GitHub
could
Dominant language
TypeScript
Stars
3
Forks
0
Avg merge
1d 9h
Merged PRs (30d)
109

Description

The current implementation of the email preview uses an iframe to display a string of HTML that we modify in response to the headline, preview text and kicker. Every change re-renders the iframe document, so the it flickers as the content is updated.

We could fix this by rendering the html inline and updating the content with query selectors directly.

This is less secure, but we are loading trusted Guardian content, so should be okay

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.