guardian / guardian/grid

Rationalise Location

Open
#3,975 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
1.5k
Forks
121
Avg merge
4d 1h
Merged PRs (30d)
29

Description

During [discussions](https://github.com/guardian/grid/discussions/3934), we touched on:
- [ ] [Remove](https://github.com/guardian/grid/blob/main/kahuna/public/js/search/structured-query/query-suggestions.js#L28) `in` chip/alias, make `location` chip [work](https://github.com/guardian/grid/blob/main/media-api/app/lib/querysyntax/QuerySyntax.scala#L147) for all Location sub-fields (like `in` has)
- [ ] Add `subLocation` chip
- [ ] Remove `location` as an alias for `subLocation` ([here](https://github.com/guardian/grid/blob/main/media-api/app/lib/querysyntax/QuerySyntax.scala#L138))
- [ ] Make `+has:location` do what it’s supposed to (return images with any location data present)
- [ ] Think a bit if four chips: `country`, `city`, `state`, `subLocation` could not have a better chip UI of offering a secondary sub-choice for a `location` key (but still allow just typing a value without specifying a subfield). This new chip UI could be reused for other “structured” chips and would simplify/shorten user journeys
- [ ] Remember we still do not support new Location schemas ([shown](https://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata#location-shown-in-the-image) and [created](https://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata#location-created)) ([here](https://github.com/guardian/grid/blob/main/common-lib/src/main/scala/com/gu/mediaservice/lib/metadata/ImageMetadataConverter.scala#L87))
- [ ] Spare a Christmas thought on normalising location metadata, providing cleaning, spelling, typeahead and GPS>location parsing (reverse geocoding, like eg. [this here](https://github.com/tedca77/IME/blob/main/README.md))

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.