guardian / guardian/grid

When both Allow and Deny cropping leases are applied, Deny should win…

Open
#3,860 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Scala
Stars
1.5k
Forks
121
Avg merge
4d 1h
Merged PRs (30d)
29

Description

## Short description
…instead Allow wins, which is not safe.

## Steps to reproduce
Ask someone to apply two active cropping leases: Allow and Deny. Try cropping image yourslef while not having edit_metadata permission. Cropping should be disabled.

## Actual results
Cropping is allowed.

## Expected results
Cropping should be denied.

## OS and browser details
All.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the case with simultaneous Allow and Deny cropping leases and without edit_metadata permission, then locate the cropping authorization logic that combines those leases. Done means the same user cannot crop when both leases are active and the behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
authorization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.