guardian / guardian/grid

Byline and Credit fields not using asciifolding

Open
#1,997 0 comments 0 reactions 0 assignees View on GitHub
enhancement metadata
Dominant language
Scala
Stars
1.5k
Forks
121
Avg merge
4d 1h
Merged PRs (30d)
29

Description

Hello,

See related https://github.com/guardian/grid/pull/1246. Usefully, one can search for "walesa" and find "wałęsa" (and _vice versa_) when the term is a part of the Description field.

Unfortunately, both Byline and Credit fields aren't working that way. Please compare:
https://[PROD]/search?query=donovan by:"Pål Hansen"
&
https://[PROD]/search?query=donovan by:"Pal Hansen"

Having ES asciifolding working for these two fields is more important than for Description and is a prerequisite to fixing inconsistencies and misspellings of photographer's names. But yes, we also need a way to opt out of this future default behaviour and search like today.

Regards
Mateusz

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.