guardian / guardian/grid

Mischievous Chips

Open
#1,801 12 comments 0 reactions 0 assignees View on GitHub
bug UX
Dominant language
Scala
Stars
1.5k
Forks
121
Avg merge
4d 1h
Merged PRs (30d)
29

Description

😈🍟
Pasted outstanding issues from below:
- [ ] duplicate search term after pressing `:` ([here](https://github.com/guardian/grid/issues/1801#issuecomment-211126306))
- [ ] embarrassingly reveal the lack of UI responsiveness when cut long enough ([here](https://github.com/guardian/grid/issues/1801#issuecomment-203310481))
- [ ] pressing `-` should not immediately launch a chip preventing one from running NOT queries! ([here](https://github.com/guardian/grid/issues/1801#issuecomment-415416068))
- [ ] collections should be suggested ([here](https://github.com/guardian/grid/issues/1801#issuecomment-206925687))
- [ ] keyboard navigation between free-text and chips is broken (left, right, tab/shift+tab)
- [ ] suggestions shouldn’t be scrollable where there is space and navigating them by arrow keys should scroll them
- [ ] chips don’t work with [arbitrary fields](https://github.com/guardian/grid/pull/3132), eg. `+"fileMetadata.colourModelInformation.hasAlpha":"true"`
- [ ] chips, when committed, end up at the beginning of the search box, ie. try typing `cats +fileType:png`. This reordering does not affect URL. But it will create problems when order of the search arguments will matter (eg. for `OR` searches)

~~~
- [x] Cannot click into search box in embedded Grid on FF.
- [x] Cannot select text.
- [x] Double-clicking to select all doesn't work if you do it in the are after the word.
- [x] When try to select text with a broad click-drag, depending on where do you start dragging (still: always within the text box area), different glitches happen in different browsers...
- [x] Cannot Paste (from the context menu).
- [x] Struggling to insert my cursor into the search field or to highlight the words in order to edit them.
~~~

Contributor guide

Open the contributing guide

Research direction

Review the unchecked behaviors in this issue, especially chip creation, keyboard navigation, suggestions, arbitrary fields, and argument ordering. Reproduce the listed search-box interactions and determine which outstanding behavior remains; done means the selected behavior works without regressing the completed cases.

Written by the indexing model from the issue text.

Assessment

Domain
frontend, search
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.