guardian / guardian/dotcom-rendering

Remove usage of `Makefile` in production environment

Open
#9,439 3 comments 0 reactions 0 assignees View on GitHub
Pick me up Team Candidate: WebX
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

The `dotcom-rendering/Makefile` is here to provide developer convenience.

In its current state, it is also used to start production scripts, with confusingly similar names:
- `start`
- `start-prod`
- `start-ci`

This means that if any file required by these commands is missing from the riff-raff artifact, the server will fail to start and enter an infinite unhealthy loop.

As we do not need the convenience of checking whether Node is available and on the correct version, or any of the DevX benefits brought about by the Makefile on the production servers, we should remove all non-development (prod, ci) tasks from the Makefile, only using it for local development and using an alternative solution for production tasks (e.g. start-prod).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.