guardian / guardian/dotcom-rendering

Improve type of Image on front card

Open
#8,863 3 comments 0 reactions 1 assignee Claimed by @DanielCliftonGuardian View on GitHub
Pick me up
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

As a follow up from #8228, we should improve the image type coming through the `enhanceCards` and `enhanceCollections` enhancers.

We should have one common `Image` type which includes `src` and `alt` as a minimum (see description on #8228)

This came up recently in [this PR](https://github.com/guardian/dotcom-rendering/pull/8860) which suggests a sensible fallback option for missing alt text, though this PR does not solve the underlying issue of the data not coming through

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.