guardian / guardian/dotcom-rendering

Support `apps.importable.tsx` files

Open
#8,841 2 comments 0 reactions 0 assignees View on GitHub
Team Candidate: WebX
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

According to these recommendations ](https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/docs/contributing/where-should-my-code-live.md#L63)we should be able to name files `.apps.importable.tsx` to distinguish which renderingTarget the code is for

This currently isn't working though, so we have (at least) 2 files that don't follow convention. We should fix this.
- AppsFooter.importable.tsx
- AdsPortal.importable.tsx

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.