guardian / guardian/dotcom-rendering
Fix fields for GA on `/Front` endpoint
Open
Team Candidate: WebX
- Dominant language
- TypeScript
- Stars
- 274
- Forks
- 34
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 121
Description
These properties should match frontend e.g. [with contentType](https://github.com/guardian/frontend/blob/main/common/app/model/DotcomContentType.scala#L31-L46).
To do this we can [make `GAData` required](https://github.com/guardian/dotcom-rendering/blob/2638f350cab67d2fd2dc1b435b6e3d6bf0f573ac/dotcom-rendering/src/model/guardian.ts#L53), and ensure that `GAData` is a good shape for Fronts.
If it isn't, having `ArtcielGAData` and `FrontGAData` could help solve the issue without coupling these types.
Contributor guide
Assessment
This issue has not been assessed yet.