guardian / guardian/dotcom-rendering
ImmersiveLayout image / headline position changes
Open
Team Candidate: Articles and Publishing
- Dominant language
- TypeScript
- Stars
- 274
- Forks
- 34
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 121
Description
Immersive logic might not be expected. E.g. in the article https://www.theguardian.com/lifeandstyle/2023/jul/04/how-we-survive-mauro-prosperi-lost-desert-raw-bats-urine
There was a change to some logic in `ImmersiveLayout` in #6762 which might have overridden some layout logic.
Intended style was 80vh for image (or nav + image?) @HarryFischer please confirm
@mxdvl has suggested when implementing fixes, consider using `dvh` which is the dynamic view height on mobile
https://caniuse.com/mdn-css_types_length_viewport_percentage_units_dynamic
https://developer.mozilla.org/en-US/docs/Web/CSS/length#dynamic
Contributor guide
Assessment
This issue has not been assessed yet.