guardian / guardian/dotcom-rendering

Inline images with weighting `immersive` obscure content/ads in the right column

Open
#5,108 5 comments 3 reactions 0 assignees View on GitHub
maintenance visual bug
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

We see images in the body of articles obscure content in the right column in some situations

1) Where the article is rendered in a browser using an ad-blocker. In this scenario the Most Viewed list is stuck to the top of the page
2) If ads are placed in the right column by space-finder then this is not aware that the image is stretching into the right column

Screenshot 2022-06-01 at 11 15 07

Should we add a flag / prop that indicates that at least one image in the article has the `immersive` weighting and pass that through to allow different decisions to be made? E.g.: We could choose to not stick Most Viewed in this situation.

@guardian/commercial-dev ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.