guardian / guardian/dotcom-rendering

Byline images in blocks are not responsive

Open
#4,505 0 comments 1 reaction 0 assignees View on GitHub
Deadblogs dotcom-rendering Liveblogs maintenance Sportblogs
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

If we want to upgrade to responsive images (`picture`/`source`/`srcset`) on DCR we need to:

- Make a PR to `frontend` to generate them and send them through (DCR can't do this atm because it requires access to the "salt" for signed URLs)
- Update the DCR model to pass through this new data to the component
- Update the component API to accept the different `srcset`s

AR already has these `srcset`s, so they can be passed through then too.

_Originally posted by @JamieB-gu in https://github.com/guardian/dotcom-rendering/pull/4369#discussion_r833153946_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.