guardian / guardian/dotcom-rendering

Render newsletter sign-up cards in Highlights using newsletter field

Open
#15,960 0 comments 0 reactions 1 assignee Claimed by @georgerichmond View on GitHub
NEWSLETTERS
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

**Context:**
Highlights containers on fronts need to display newsletter sign-up cards when the card's pressed data supplies newsletter metadata.

**Tasks:**
- Add an optional `newsletter` field to FEFrontCard/DCRFrontCard types and schema.
- In `enhanceCards`, map newsletter data from FE to DCR card shape.
- In ScrollableHighlights, if `trail.newsletter` exists, render a new NewsletterHighlightsCard with supplied metadata (identityName, name, description, frequency, illustration, etc). Otherwise render a normal HighlightsCard.
- Match the look and dimensions of other highlights cards.
- Reference frontend issue for source data.

_See: https://github.com/guardian/email-rendering/issues/948_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.