guardian / guardian/dotcom-rendering
404 on most viewed footer tab
Open
- Dominant language
- TypeScript
- Stars
- 274
- Forks
- 34
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 121
Description
User help reported 404s being thrown when clicking on a tab in the most viewed tab:
> It happened after selecting 'Across the Guardian' at https://www.theguardian.com/us-news
Chat threads:
https://chat.google.com/room/AAAAG9rU0m0/ekqc0yTjh8M/ekqc0yTjh8M?cls=10
https://chat.google.com/room/AAAAPTsU18A/zDtQ6A2Lk0U/zDtQ6A2Lk0U?cls=10
TLDR:
The links for the tabs are not valid links so when the associated JS runs and errors the link is followed and generates a 404.
Options are:
- handle JS errors
- make the link a valid fragment link
- use CSS entirely for switching tabs
More discussion in the chat thread above
Contributor guide
Assessment
This issue has not been assessed yet.