guardian / guardian/dotcom-rendering

Apply `grid` module to interactive layout(s)

Open
#15,165 3 comments 0 reactions 1 assignee Claimed by @frederickobrien View on GitHub
maintenance
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

This came up while working on #15123. It would be an awful lot easier to handle full width elements and the occasional DOM manipulation on interactive pieces if the grid layout of the template spanned the full viewport width. Then stuff like `fullWidth` weighting would be a CSS-friendly one-liner rather than a bunch of negative left margins.

As with most things interactives related this potentially opens a can of worms. Even if we can successfully update the templates to use the `grid` module, will old atoms work or will they break horribly? Would we need a before/after fork? And what kind of precedent would that set?

One to explore.

Alternative thought: make [revamped `StandardLayout`](https://github.com/guardian/dotcom-rendering/pull/15428) the new interactive layout?

## Context and useful links

- https://github.com/guardian/dotcom-rendering/pull/3626

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.