guardian / guardian/dotcom-rendering

Handle error when More Galleries data can't be fetched

Open
#14,629 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

When most viewed galleries request made from the client, is failed, we are returning null. But before the fetch call is made we have already placed a `Placeholder` section with a height quite near the resulting component. So returning null is going to remove the `Placeholder` hence causing layout shift.

We need to handle the error differently to ovoid this layout shift.

More details in @JamieB-gu 's comment in [here](https://github.com/guardian/dotcom-rendering/pull/14545#discussion_r2406830588)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.