guardian / guardian/dotcom-rendering

[Bug]: 5:4 trail image squeezed into 4:5 front card

Open
#14,289 1 comment 0 reactions 0 assignees View on GitHub
Bug Rota
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

### What happened?

Never-ever should images be squeezed in any direction, anywhere. I bet there is `object-fit` option that will work correctly. Here [is](https://www.theguardian.com/europe#features) (now fixed) a 4:5 card (`static/feature/2`)

Image

with a 5:4 Composer trail squeezed badly. Dug up an image from HTML ([here](https://i.guim.co.uk/img/media/dcb54c7b4634c45141a9eeaaf92efdd3efa95831/0_0_16176_12941/master/16176.jpg?width=460&dpr=2&s=none&crop=4%3A5)):

![Image](https://github.com/user-attachments/assets/382c2f8b-4da3-401f-971f-197c16f48941)

Of course, it should have been fixed by a human [EDIT: and indeed it has], by providing a replacement like on the left (frontstool has not indicated an active image replacement for this card). Nevertheless, platform should not be wrong here. Humans are fallible. Especially on a Sunday.

### Where is this happening?

https://www.theguardian.com/europe#features

### What is the impact?

With a photo of a human face the impact would be bigger.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.