guardian / guardian/dotcom-rendering

The caption icon is there even when there's no image caption or credit

Open
#14,042 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

The main media in this article https://www.theguardian.com/science/grrlscientist/2012/aug/07/3 does not have a caption and it also doesn't have display credit set to true. But the `i` icon appears on mobile view and clicking on it, nothing happens. This works properly on frontend version https://www.theguardian.com/science/grrlscientist/2012/aug/07/3?dcr=false

Image

This seems to be the case in DCAR for all articles. We need to make sure the icon only appears when either of caption or credit is available.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.