guardian / guardian/dotcom-rendering

Ignore match stats on competitions matches with no access to premium data

Open
#13,824 0 comments 0 reactions 0 assignees View on GitHub
Sport
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

Currently in frontend we have logic that checks if all stats fields are zero and if yes, it decides that the match doesn't have stats or we don't have access to the stats. But PA seems to be inconsistently returning the non-zero values for some matches where we are not subscribed to match stats and these values are sometimes ending up as incorrect.

PA is currently finding it not possible to make this behaviour consistent for the competition matches where we are not signed up for the match stats. They suggest that we implement logic on our side to ignore the Premium data based on our agreement.

Please refer to this [conversation](https://groups.google.com/a/guardian.co.uk/g/dotcom.platform/c/1eqQi9kdW_M) that was an issue with the match stats reported by Gracie Daw.

Also take a look at the [conversation](https://groups.google.com/a/guardian.co.uk/g/dotcom.platform/c/UzHeyxtPfTE) with PA in regards to this issue

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.