guardian / guardian/dotcom-rendering

Fix skipped Chromatic tests

Open
#13,046 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

There are a number of Chromatic tests that have been [skipped](https://github.com/guardian/dotcom-rendering/pull/13017) because they often recorded false positives and slowed down the development workflow. These tests should be investigated, fixed and reinstated.

- [ ] [VimeoComponent](https://github.com/guardian/dotcom-rendering/blob/121ed9b88e29cb6f5d351b400df429565828dc3c/dotcom-rendering/src/components/VimeoBlockComponent.stories.tsx#L32)
- [ ] [DecideLayout component: Web Photo Essay Immersive Labs Light](https://github.com/guardian/dotcom-rendering/blob/121ed9b88e29cb6f5d351b400df429565828dc3c/dotcom-rendering/src/layouts/DecideLayout.stories.tsx#L240)
- [ ] [Layout:Design: Match Report, Display: Standard, Theme: Sport & Layouts:Match Report](https://github.com/guardian/dotcom-rendering/blob/121ed9b88e29cb6f5d351b400df429565828dc3c/dotcom-rendering/src/components/ArticleHeadline.stories.tsx#L275)
- [ ] [Discussion Comments App: when logged in, with no picks and not expanded](https://github.com/guardian/dotcom-rendering/blob/121ed9b88e29cb6f5d351b400df429565828dc3c/dotcom-rendering/src/components/Discussion/Comments.stories.tsx#L164)
- [ ] [DocumentBlockComponent:document embed](https://github.com/guardian/dotcom-rendering/blob/121ed9b88e29cb6f5d351b400df429565828dc3c/dotcom-rendering/src/components/DocumentBlockComponent.stories.tsx#L57)

[Spreadsheet tracker: Chromatic false positives](https://docs.google.com/spreadsheets/d/1FvItNTMFXIpI4rCrZ4mQ0CRouT06sSVro168f6oKPm4)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.