guardian / guardian/dotcom-rendering

Remove dependency on make from DCAR in production

Open
#12,934 1 comment 0 reactions 0 assignees View on GitHub
Team Candidate: WebX
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

make affords us some developer convenience over npm scripts, by abstracting away package managers.

However its use in production is surprising, since it's usually considered a build tool. This, and the fact that this dependency was implicit, led to a production incident after make was removed from a group of dependencies in DCAR's AMI image.

Not relying on make being available as a production dependency is a [retro action](https://docs.google.com/document/d/1j_VzATNPqCthpciKh9Fi7PmNMHF0SMYgb-pKRFwKjQs/edit?tab=t.0) from this incident

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.