guardian / guardian/dotcom-rendering

Remove global styles from DCR

Open
#11,977 0 comments 0 reactions 0 assignees View on GitHub
Pick me up Team Candidate: WebX
Dominant language
TypeScript
Stars
274
Forks
34
Avg merge
2d 22h
Merged PRs (30d)
121

Description

DCR has some global styling:

https://github.com/guardian/dotcom-rendering/blob/810053789c322c946553ba4a3bed907e7c57c627/dotcom-rendering/src/components/ArticleBody.tsx#L55-L101

This was introduced at a time when DCR was getting the HTML from CAPI and setting it in the page without separating any elements. After:

* https://github.com/guardian/dotcom-rendering/pull/7956

we are parsing the HTML and we can now control the styles better for each element, so the global styling can be removed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.