guardian / guardian/dotcom-rendering
Improve Name And Implementation Of `enhanceElementsImages`
Open
good first issue
Pick me up
Team Candidate: WebX
- Dominant language
- TypeScript
- Stars
- 274
- Forks
- 34
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 121
Description
https://github.com/guardian/dotcom-rendering/blob/5916d46b86dfefbf2a817c93d207516fd114533d/dotcom-rendering/src/model/enhance-images.ts#L448-L457
1. The name is unclear, perhaps it should be `enhanceMainMediaImages`.
2. Why does `isPhotoEssay` include a check for labs? And why is it different to: https://github.com/guardian/dotcom-rendering/blob/5916d46b86dfefbf2a817c93d207516fd114533d/dotcom-rendering/src/model/enhance-images.ts#L432-L435
Contributor guide
Assessment
This issue has not been assessed yet.