guardian / guardian/csnx

Social icons are not vertically centred

Open
#259 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
45
Forks
9
Avg merge
1d 9h
Merged PRs (30d)
17

Description

The position of the SvgGoogleBrand and SvgAppleBrand icons is too high when they are using in Button

Screenshot 2021-06-21 at 10 21 46

It looks like they are not vertically centred in the 30x30 viewbox?
Screenshot 2021-06-21 at 10 21 37

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the SvgGoogleBrand and SvgAppleBrand components and the Button implementation, then inspect how the icons are positioned within the 30x30 viewBox. Done means both social icons appear vertically centred in Button, matching the intended alignment shown by the screenshots.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
design, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.