Consider renaming "current" to "copy" and "notebook" to "link" on the image attachment dialog.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 6.1k
- Forks
- 537
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 4
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug. Not a question or feature request.
- The topic is not already reported at Issues. (I've searched it).
- Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
- The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)
Description
I want to attach an image to Markor. For example, I had to quickly take a photo using phone's camera, did not have time to open Markor and create a directory or and .md file, and only got to sorting out photos after coming home.
The image attachment dialog has the following text:
Copy file
The file is not located in the current folder. Do you want to copy it to the current folder? This will overwrite any existing file with the same name.
And three answers:
Notebook, Cancel, Current
Okay, my first language is not English, but I find that only for "Cancel" it is clear what the button does.
The question is "Do you want to copy?" The answer to such a question would be "Yes, I do want to copy" or "No, I do not want to copy". None of these options is given in the dialog. By trial and error I found that "Current" is equivalent to "Yes, I want to copy", and "Notebook" is equivalent to "I do not want to copy, but I want to add a link to that file, wherever it may be".
Would it make sense to rename the "current" answer to "copy", and "notebook" to "link"?
I have been using Markor for years, and I keep forgetting what those options mean! :(
Steps to reproduce
- Create an .md note
- Tap the binder button -> Image -> browse
- Select some image
Information
Android version: 9
Device: OnePlus 5t
App Version: master
Source
git master branch
Format / File type
Not specific
Additional info / Log
-
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the image attachment dialog using the listed steps: create an .md note, tap binder → Image → browse, and select an image outside the current folder. Locate the dialog's label resources or implementation from that flow. Done means the choices clearly communicate copying versus adding a link, while Cancel remains available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100