gruns / gruns/furl

test!: Path `////path` causing failures

Open
#185 2 comments 1 reaction 1 assignee Claimed by @alexcochran View on GitHub
Dominant language
Python
Stars
2.8k
Forks
165
PR merge metrics
No merged PRs in 30d

Description

The path `////path` is causing issues with [most of the test fixtures.](https://github.com/gruns/furl/actions/runs/17632734482/job/50103086846)

Image

https://github.com/gruns/furl/blob/f53defbf075e6f31c5b910aefb4221abe5b937cf/tests/test_furl.py#L1627C28-L1631C29

This is caused by the output of `f.url == '//////path'` instead of `'////path'`. This may be due to a change in the urllib library, but I am not sure.

The output of calling `urllib.parse.unparse` here:
https://github.com/gruns/furl/blob/f53defbf075e6f31c5b910aefb4221abe5b937cf/furl/furl.py#L1826C9-L1832C11

actually generates the expected number of slashes:

Image

**However**, because of [this code](https://github.com/gruns/furl/blob/f53defbf075e6f31c5b910aefb4221abe5b937cf/furl/furl.py#L1838C30-L1840C33), an extra 2 slashes are prepended, causing the output of `f.url` to be invalid.

> [!NOTE]
> This issue does not appear on python 3.8, but appears on all other tests, so this could be a problem caused by a change in the standard library, in which case, other functionality may need reviewing

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.