gruns / gruns/furl

Seems to be a bug when paring multiple '@'s ?

Open
#163 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2.8k
Forks
165
PR merge metrics
No merged PRs in 30d

Description

Hi,

I notice one difference by applying differential testing with urllib.parse.

Case 1:

```
URL = "https://@david:passwd@testing.xyz"
f = furl(URL)
```
Error: ValueError: Invalid port 'passwd@testing.xyz'. However, it should access the host 'testing.xyz' with username '@david' and password 'passwd'.

Case 2:

```
URL = "https://aa@bb@testing.xyz"
f = furl(URL)
```
Error: ValueError: Invalid host 'bb@testing.xyz'. However, it should access the host 'testing.xyz' with username 'aa@bb'.

When parsing multiple '@'s, I think the domain should be sliced by the last '@' rather than the first '@'.

Thanks,
Yuancheng

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.