grpc / grpc/grpc.io

Revisit build commands

Open
#570 0 comments 0 reactions 1 assignee Claimed by @chalin View on GitHub
docsy e0-minutes e1-hours infrastructure p2-medium
Dominant language
HTML
Stars
479
Forks
545
Avg merge
2d 7h
Merged PRs (30d)
5

Description

Context: https://github.com/grpc/grpc.io/pull/561#discussion_r544440860

> We don't want to fetch the latest `docsy` repo version (which is what the `git submodule update ...` command does AFAIK), we want to stick to the submodule version that is associated with this repo via `.gitmodules`. Otherwise a build on Netlify might (unknown to us) be different from local builds.
>
> AFAIK, it shouldn't be necessary to add this extra `git` command (unless the `docsy` repo itself has submodules).

This needs to be further investigated. Currently, the modified build commands are part of `netlify.toml`. Some refactoring my be in order, including a shift of commands towards the `Makefile`. (I'd actually vote for dropping make in favor of simple npm scripts (if those are powerful enough), or possibly gulp.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.