grpc / grpc/grpc-web

Wrong return values for setters when generating .d.ts typings

Open
#917 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9.3k
Forks
802
Avg merge
1d 7h
Merged PRs (30d)
5

Description

Aloha!

When I generate `.d.ts` typings with any grpc-web version > 1.0.7 all setter-functions now return their class rather than `void`.

E.g. what I expect:
`setToken(value: Uint8Array | string): void;`

What is generated:
`setToken(value: Uint8Array | string): SaltEntry`

I guess this is because of a bug introduced with commit #747 (line 924, 927).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.