grpc / grpc/grpc-web

Generator redeclares same function name when given a proto with multiple services

Open
#322 1 comment 1 reaction 0 assignees View on GitHub
codegen
Dominant language
JavaScript
Stars
9.3k
Forks
802
Avg merge
1d 7h
Merged PRs (30d)
5

Description

When give `.proto` file of such
```
...
service FirstService {
rpc List (ObjectA) returns (ObjectA) {}
}

service SecondService {
rpc List (ObjectB) returns (ObjectB) {}
}
```

The `protoc` generator will generate the following stub using `mode=grpcwebtext`

```
...
const methodInfo_List = new grpc.web.AbstractClientBase.MethodInfo(
proto.servicename.ObjectB,
...
);

// and another one with the same name
const methodInfo_List = new grpc.web.AbstractClientBase.MethodInfo(
proto.servicename.ObjectA,
...
);
```

which results in a `SyntaxError`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.