grpc / grpc/grpc-web

import public not supported in TypeScript code generator

Open
#1,339 3 comments 0 reactions 0 assignees View on GitHub
enhancement Help welcome! typescript
Dominant language
JavaScript
Stars
9.3k
Forks
802
Avg merge
1d 7h
Merged PRs (30d)
5

Description

It looks like `import public` feature of Protofile is not supported correctly when generating TypeScript code.

The generated code contains plain `import * as ` in the file that corresponds to the Protofile with `import public`, and so the file where the _transitive_ type is used is invalid, because of missing import. As TypeScript doesn't support a feature like `import public` (IMHO), the code generator should generate the _transitive_ imports _manually_.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.