grpc / grpc/grpc-rust

Confusing MSRV

Open
#866 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
12.5k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
24

Description

## Bug Report

### Version

0.6.2 - all of them

### Platform

Irrelevant

### Description

MSRV was previously 1.39, then it [switched to 1.56](https://github.com/hyperium/tonic/commit/debcafe08cd64f03bff2fee0eaa1521e47794a8a#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5) and later the [edition was updated but not the version](https://github.com/hyperium/tonic/commit/101f2f76d4a62757cac8ca209b1eb6b57094d524#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5). This doesn't seem intended.

The CI also doesn't enforce MSRV, and it's not configured in `clippy.toml`.

I've previously said I'd like MSRV to be no greater than 1.48.0 but this specific request wasn't explicitly accepted nor denied.
`tonic-build` fails to compile on 1.48 due to #805 (it succeeds after patching it), which was cosmetic so hopefully this can be reverted?

If 1.48.0 or lower is accepted I'm willing to make a PR to:

* Fix compilation
* Add `clippy.toml`
* Improve CI to enforce MSRV
* Update the documentation

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.