grpc / grpc/grpc-rust

grpc: improve examples

Open
#2,661 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
12.5k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
24

Description

1. The grpc examples share a cargo package with tonic's examples. Tonic's examples require protoc in your PATH which we'd like to avoid as a strict requirement for grpc. We should move the grpc examples to `grpc/examples`, or move the tonic examples to `tonic/examples`.

2. The grpc examples currently use a `build.rs` method that requires rebuilding every time, because it outputs the files into `src` and cargo considers them dirty even though they were produced deterministically during the build process. Instead we should output them into the OUT_DIR, and commit them into another (non-src/...) directory and copy them into OUT_DIR from there when not regenerating from them with protoc (so the examples are trivially runnable).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.