grpc / grpc/grpc-rust

Issue when combining with tonic-rest

Open
#2,586 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
12.5k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
24

Description

## Bug Report

### Version
0.14.5

### Platform

### Crates

### Description

issue when working with tonic-rest https://github.com/hyperium/tonic/blob/master/tonic-web/src/service.rs#L111 should continue processing similar to https://github.com/hyperium/tonic/blob/master/tonic-web/src/service.rs#L101
When executing tonic-rest only http2 works

```rust
Server::builder()
.accept_http1(true)
.layer(tonic_web::GrpcWebLayer::new())
.add_routes(
proto::rest::proto_rest_router(Arc::new(
some_service_with_no_interceptors.clone(),
))
.into(),
)
.serve_with_shutdown(address, async {
match signal {
Some(signal) => signal.cancelled().await,
None => std::future::pending::<()>().await,
}
})
.await?;
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.