grpc / grpc/grpc-rust

Close listening socket on graceful shutdown

Open
#2,342 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
12.5k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
24

Description

## Feature Request

### Crates

tonic

### Motivation

- listening socket will never be served, so holding it is pointless
- but it is helpful for testing behavior like reconnecting on server restart

### Proposal

In the middle of here:

https://github.com/hyperium/tonic/blob/d4e4a2aaf6de36f5018c5f854d545e0439800b80/tonic/src/transport/server/mod.rs#L768-L770

add

```
drop(incoming);
```

### Alternatives

Use your own incoming and connect it to the same signal.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.