grpc / grpc/grpc-rust

Released version of tonic_health contains blobs

Open
#2,019 5 comments 4 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
12.5k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
24

Description

## Bug Report

### Version

tonic_health: 0.12.3

### Platform

Unrelated, code is uploaded on crates.io

### Crates

Tonic-Health

### Description

While reviewing a dependency update for tonic-health I noticed that it contains a binary file: https://diff.rs/tonic-health/0.12.2/0.12.3/src%2Fgenerated%2Fgrpc_health_v1.bin

That is not desirable as it makes reviewing dependencies harder. It also might hide potential attacks.
In this case I believe the blob is just the binary representation of the proto file and that it was accidentally uploaded to crates.io. Please consider to explicitly exclude this file for future updates.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.