grpc / grpc/grpc-rust

Remove timeout handling from `Endpoint::connect_with_connector`

Open
#1,555 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
12.5k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
24

Description

## Feature Request

### Crates

- tonic

### Motivation

Reduces transport's responsibility.

### Proposal

> [!WARNING]
> This proposal includes a breaking change.

Removes timeout handling from [`tonic::transport::channel::Endpoint::connect_with_connector`](https://docs.rs/tonic/0.10.2/tonic/transport/channel/struct.Endpoint.html#method.connect_with_connector) method.

By this proposal (and #1497), tonic can remove `hyper-timeout` from dependencies. This simplifies `tonic`'s dependency tree, responsibility and implementations. And also it makes easier a little the future migrating to `hyper` 1.0.

`tonic` user can apply timeout as of the [timeout example](https://github.com/hyperium/tonic/blob/b3fca19104bf001d3a3dac74221b7c9bede13cf1/examples/src/timeout/client.rs).

### Alternatives

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.