grpc / grpc/grpc-rust

Certificate::from_pem does an unnecessary copy

Open
#1,277 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
12.5k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
24

Description

### Version

0.8.3

### Platform

no.

### Crates

tonic

### Description

This line https://github.com/hyperium/tonic/blob/555a8bcf422b6c32ccda78834ec781f8b6f0e564/tonic/src/transport/tls.rs#L21 does an unnecessary copy of the certificate, which in the case of multi-pem root stores may be large. Suggest adding a `from_pem_vec`-style function that takes ownership of a `Vec` instead.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.